Skip to content

Remove storage sync services in resource cleanup#14196

Merged
benbp merged 1 commit intoAzure:mainfrom
benbp:benbp/delete-storage-sync
Mar 4, 2026
Merged

Remove storage sync services in resource cleanup#14196
benbp merged 1 commit intoAzure:mainfrom
benbp:benbp/delete-storage-sync

Conversation

@benbp
Copy link
Member

@benbp benbp commented Feb 26, 2026

Remove storage sync services in resource cleanup

Copilot AI review requested due to automatic review settings February 26, 2026 21:45
@benbp benbp requested a review from a team as a code owner February 26, 2026 21:45
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Feb 26, 2026
@benbp benbp self-assigned this Feb 26, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Storage Sync Service cleanup to prevent leaked Storage Sync resources from blocking resource group deletion during test resource teardown.

Changes:

  • Introduces Remove-StorageSyncServices helper to remove Storage Sync Services (and dependent sync groups/endpoints) prior to RG deletion.
  • Invokes the new helper from Remove-TestResources.ps1 during resource cleanup.
  • Updates default subscription selection messaging/behavior and adds a well-known subscription entry.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
eng/common/scripts/Helpers/Resource-Helpers.ps1 Adds helper that enumerates Storage Sync Services and deletes endpoints/groups/services to unblock RG deletion.
eng/common/TestResources/Remove-TestResources.ps1 Calls the new helper during cleanup; adjusts subscription selection defaults and subscription name map.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp force-pushed the benbp/delete-storage-sync branch from b87ac23 to c67206f Compare February 26, 2026 22:05
@benbp benbp moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 📆🎇 Feb 26, 2026
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp force-pushed the benbp/delete-storage-sync branch from c67206f to 324eb63 Compare February 26, 2026 22:19
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Mar 4, 2026
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#14196 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
azure-sdk added a commit to Azure/azure-sdk-for-rust that referenced this pull request Mar 4, 2026
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#14196 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
@benbp benbp merged commit 1506b7e into Azure:main Mar 4, 2026
10 checks passed
@benbp benbp deleted the benbp/delete-storage-sync branch March 4, 2026 20:55
@kurtzeborn kurtzeborn moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 📆🎇 Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team.

Projects

Status: 🎊 Closed

Development

Successfully merging this pull request may close these issues.

4 participants